Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use page objects for favicon test #2498

Merged
merged 3 commits into from
Oct 4, 2023
Merged

refactor: use page objects for favicon test #2498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0f53e9
refactor: use page objects for favicon test
swalchemist Sep 22, 2023
5586fdf
doc: reword
swalchemist Sep 22, 2023
43a2e1f
refactor: import class
swalchemist Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/SamlLoginIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import org.cloudfoundry.identity.uaa.ServerRunning;
import org.cloudfoundry.identity.uaa.account.UserInfoResponse;
import org.cloudfoundry.identity.uaa.constants.OriginKeys;
import org.cloudfoundry.identity.uaa.integration.pageObjects.FaviconElement;
import org.cloudfoundry.identity.uaa.integration.pageObjects.LoginPage;
import org.cloudfoundry.identity.uaa.integration.util.IntegrationTestUtils;
import org.cloudfoundry.identity.uaa.integration.util.ScreenshotOnFail;
Expand Down Expand Up @@ -465,8 +466,11 @@ public void testGroupIntegration() throws Exception {

@Test
public void testFavicon_Should_Not_Save() throws Exception {
webDriver.get(baseUrl + "/favicon.ico");
testSimpleSamlLogin("/login", "Where to?", MARISSA4_USERNAME, MARISSA4_PASSWORD);
createIdentityProvider(SAML_ORIGIN);
FaviconElement.getDefaultIcon(webDriver, baseUrl);
LoginPage.go(webDriver, baseUrl)
.clickSamlLink_goToSamlLoginPage()
.login_goToHomePage(MARISSA4_USERNAME, MARISSA4_PASSWORD);
}


Expand Down
24 changes: 24 additions & 0 deletions uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/FaviconElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package org.cloudfoundry.identity.uaa.integration.pageObjects;

import org.openqa.selenium.WebDriver;

import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.endsWith;
import static org.junit.Assert.assertThat;

public class FaviconElement extends Page {

// The favicon.ico image is not present on the server because we specify a custom icon URL
// in the headers, but browsers try to hit it and tests need to hit this default URL.
static public FaviconElement getDefaultIcon(WebDriver driver, String baseUrl) {
driver.get(baseUrl + "/favicon.ico");
return new FaviconElement(driver);
}

// Expect a 404 error when landing on the favicon URL.
public FaviconElement(WebDriver driver) {
super(driver);
assertThat("Should be on the favicon image", driver.getCurrentUrl(), endsWith("/favicon.ico"));
assertThat(driver.getPageSource(), containsString("Something went amiss."));
}
}