Skip to content
This repository was archived by the owner on Jan 29, 2025. It is now read-only.

Bump ajv from v6.12.6 to v8.10.0 #1556

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

Pooja-08
Copy link

@Pooja-08 Pooja-08 commented Mar 3, 2022

ajv v8.x doesn't support metaschema for draft-04. A new library ajv-draft-04 is added to support draft-04 schema validation.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/181443179

The labels on this github issue will be updated when the story is started.

@coveralls
Copy link

coveralls commented Mar 3, 2022

Pull Request Test Coverage Report for Build 5899

  • 11 of 20 (55.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 87.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
broker/applications/osb-broker/src/api-controllers/middleware/index.js 11 20 55.0%
Totals Coverage Status
Change from base Build 5888: -0.06%
Covered Lines: 9758
Relevant Lines: 10721

💛 - Coveralls

@Pooja-08 Pooja-08 force-pushed the dev/library_upgrades branch from e063156 to d7eec77 Compare March 3, 2022 06:58
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #1556 (d7eec77) into master (c55f0d6) will decrease coverage by 1.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
- Coverage   73.96%   72.83%   -1.13%     
==========================================
  Files          45       45              
  Lines        4348     4348              
==========================================
- Hits         3216     3167      -49     
- Misses        805      844      +39     
- Partials      327      337      +10     

@Pooja-08 Pooja-08 requested a review from a team March 3, 2022 07:05
@Pooja-08 Pooja-08 added dependencies Pull requests that update a dependency file PipeLine:Green and removed unscheduled labels Mar 4, 2022
Copy link
Contributor

@anoopjb anoopjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pooja-08 Pooja-08 merged commit eb5a282 into cloudfoundry:master Mar 9, 2022
jintusebastian pushed a commit to jintusebastian/service-fabrik-broker that referenced this pull request May 17, 2022
* Bump ajv from 6.12.6 to 8.10.0

* Add docs for schema validation using ajv library
jintusebastian pushed a commit to jintusebastian/service-fabrik-broker that referenced this pull request Feb 13, 2023
* Bump ajv from 6.12.6 to 8.10.0

* Add docs for schema validation using ajv library
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file PipeLine:Green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants