Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance test for file based service bindings on Windows #1437

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

klapkov
Copy link

@klapkov klapkov commented Feb 7, 2025

What is this change about?

Added an acceptance test for validating file based service bindings on windows diego cells. The test will run if include_windows is enabled. I decided to re-use the catnip application for this test, since it is already adapted for such a test. That's why we build an catnip.exe. The test itself is the same as: https://github.com/cloudfoundry/cf-acceptance-tests/blob/main/file_based_service_bindings/file_based_service_bindings.go just tweaked a bit.

Please provide contextual information.

Follow up to cloudfoundry/community#901 and #1374.

What version of cf-deployment have you run this cf-acceptance-test change against?

v46.5.0 with modified capi and diego releases

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config (include_windows must be set to true)

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

~ 1 minute for the whole test

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Copy link
Member

@ctlong ctlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please integrate the file-based service binding config parameter as well by gating the tests on GetIncludeFileBasedServiceBindings()

@klapkov
Copy link
Author

klapkov commented Feb 12, 2025

Hey @ctlong, I addressed the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants