Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot delete deployment using example from README as manifest parameter is required #34

Closed
rmeharg opened this issue Dec 13, 2017 · 2 comments
Closed

Cannot delete deployment using example from README as manifest parameter is required #34

rmeharg opened this issue Dec 13, 2017 · 2 comments

Comments

@rmeharg
Copy link

rmeharg commented Dec 13, 2017

Should this parameter be optional as it is not needed to delete the deployment?

Or should the README example be updated to include the manifest parameter?
drich10 added a commit that referenced this issue Dec 13, 2017
@drich10
Fix readme example for delete on out
5c31dc0 
#34
@drich10
Copy link
Contributor

drich10 commented Dec 13, 2017

Hey there, sorry for the misleading example. In the future I may remove the requirement, but it required more work to make it conditionally optional on the out command. I have updated the README to be a better example for now.

drich10 added a commit that referenced this issue Dec 13, 2017
@drich10
No longer require manifest param on delete
f8ca6dd 
#34
@drich10
Copy link
Contributor

drich10 commented Dec 13, 2017

After some further evaluation and a little more caffeine I went ahead and made the change which is now available in 2.8.1+. Thanks for raising this!

@drich10 drich10 closed this as completed Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drich10 @rmeharg