This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
add support for generating basic-auth secret types #6
Merged
manno
merged 6 commits into
cloudfoundry-incubator:master
from
tomkennedy513:basic-auth-type-generation
Jul 6, 2020
Merged
add support for generating basic-auth secret types #6
manno
merged 6 commits into
cloudfoundry-incubator:master
from
tomkennedy513:basic-auth-type-generation
Jul 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow for optionally passing in username instead of generating Co-authored-by: Aidan Obley <[email protected]>
edwardstudy
previously requested changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add description in docs?
manno
reviewed
Jul 2, 2020
@tomkennedy513 sorry about the red integration test, we have this check if all examples have a test. Mostly works the other way around and checks if we remembered to increase the number... |
@edwardstudy Added doc. @manno Is there something we should do to fix the test failures? Is there a number we should bump somewhere? |
Hey, yes the tests fail here: e2e/kube/examples_count_test.go:12 |
- in light of adding the basic-auth type example
manno
approved these changes
Jul 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Aidan Obley [email protected]