This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
Allow user to specify link display text by subclassing UriCell
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2013 17:29
Currently a user needs to write a custom Cell class in order to format
URLs with an alternate display text. This requires implementing the
render method and thus duplicating logic in `UriCell`. This commit
allows display text to be specified by subclassing `UriCell` and
implementing a single function `displayText`. E.g. in coffeescript:
class MyUriCell extends Backgrid.UriCell
displayText: -> @model.get('my_field_name')
Conflicts: lib/backgrid.js
The test function was originally created by copying the test function for UriCell. This commit makes changes to the custom-display-link test that were subsequently made to the vanilla UriCell test.
wyuenho
added a commit
that referenced
this pull request
Mar 27, 2013
Allow user to specify link display text by subclassing `UriCell`
Closed
dandavison
pushed a commit
that referenced
this pull request
Mar 28, 2013
These changes were mistakenly applied only to /lib/backgrid.js
wyuenho
added a commit
that referenced
this pull request
Mar 28, 2013
Apply #88 changes to src/cell.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #81. See #41.
This PR allows users to control the display text of a link formatted by
UriCellby overriding a functiondisplayText. The existing solution is to write a custom cell class, which requires duplication of logic in the render method; with this PR the operation is more straightforward and does not duplicate any logic in the render method.The PR includes one new test: