This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
exitEditMode getting called twice on move command #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using move commands (tab, arrows, etc.), the
exitEditMode
method of the editor is being called twice. You can see the error here by simply using a move command.The reason is, here, when you call
enterEditMode
, thepostRender
method of the new cell editor callsfocus
on the new editor element, which results in ablur
event on the old editor. ThesaveOrCancel
method is then called again on the old editor, and then triggers thebackgrid:edited
event a second time.You can resolve this simply by moving this line before the
if
block, to make sure that the old editor is actually removed before entering in the new editor.