Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vite-plugin): skip node_compat test for now due to flakiness #8217

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Feb 21, 2025

Skips flaky vite-plugin test


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: skips test
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: skips test
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: skips test

@CarmenPopoviciu CarmenPopoviciu requested review from a team as code owners February 21, 2025 15:51
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 66f80b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CarmenPopoviciu CarmenPopoviciu added the skip-pr-description-validation Skip validation of the required PR description format label Feb 21, 2025
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-wrangler-8217

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8217/npm-package-wrangler-8217

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-wrangler-8217 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-cloudflare-workers-bindings-extension-8217 -O ./cloudflare-workers-bindings-extension.0.0.0-v6ce327fcc.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v6ce327fcc.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-create-cloudflare-8217 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-cloudflare-kv-asset-handler-8217

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-miniflare-8217

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-cloudflare-pages-shared-8217

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-cloudflare-unenv-preset-8217

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-cloudflare-vite-plugin-8217

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-cloudflare-vitest-pool-workers-8217

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-cloudflare-workers-editor-shared-8217

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-cloudflare-workers-shared-8217

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460366963/npm-package-cloudflare-workflows-shared-8217

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin
Copy link
Contributor

I will follow up with a fix and re-enablement.

@CarmenPopoviciu CarmenPopoviciu merged commit ed5ebdc into main Feb 21, 2025
23 of 28 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/disable-test branch February 21, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants