Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vite-plugin-cloudflare] chore: simplify the modules externalization logic #8214

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dario-piotrowicz
Copy link
Member

The changes here remove the shouldExternalize logic from our __VITE_INVOKE_MODULE__ function.

I've been looking into this so I figured I might as well just open a PR for this change, although now I'm not sure if this is really
simplifying the externalization logic or simply moving complexity from one place to another 😕


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: this functionality is already tested
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not wrangler related
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: an internal refactoring, no behavioral changes

@dario-piotrowicz dario-piotrowicz added the vite-plugin Relating to the `@cloudflare/vite-plugin` package label Feb 21, 2025
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 13b6038

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dario-piotrowicz dario-piotrowicz force-pushed the dario/simplify-externlization branch from e7182d1 to 13b6038 Compare February 21, 2025 11:53
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-wrangler-8214

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8214/npm-package-wrangler-8214

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-wrangler-8214 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-cloudflare-workers-bindings-extension-8214 -O ./cloudflare-workers-bindings-extension.0.0.0-v7a3385eeb.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v7a3385eeb.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-create-cloudflare-8214 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-cloudflare-kv-asset-handler-8214

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-miniflare-8214

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-cloudflare-pages-shared-8214

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-cloudflare-unenv-preset-8214

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-cloudflare-vite-plugin-8214

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-cloudflare-vitest-pool-workers-8214

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-cloudflare-workers-editor-shared-8214

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-cloudflare-workers-shared-8214

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13456244409/npm-package-cloudflare-workflows-shared-8214

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vite-plugin Relating to the `@cloudflare/vite-plugin` package
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant