[vite-plugin-cloudflare] chore: simplify the modules externalization logic #8214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here remove the
shouldExternalize
logic from our__VITE_INVOKE_MODULE__
function.I've been looking into this so I figured I might as well just open a PR for this change, although now I'm not sure if this is really
simplifying the externalization logic or simply moving complexity from one place to another 😕