Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fixtures): add d1 fixture tests #8213

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Feb 21, 2025

This PR adds a test in the d1-worker-app fixture. This automated test will cover changes introduced by #8175. This PR needs to be merged in order for us to land those changes.

Fixes #00000

How this was additionally tested
After creating the test, I first ran it against the wrangler version that didn't contain the d1 changes

Screenshot 2025-02-21 at 12 12 49

then ran it again against the wrangler version that contained the changes

Screenshot 2025-02-21 at 12 13 06
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: just adds fixture test
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: just adds fixture test

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner February 21, 2025 11:31
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 44382d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 21, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-wrangler-8213

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8213/npm-package-wrangler-8213

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-wrangler-8213 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-cloudflare-workers-bindings-extension-8213 -O ./cloudflare-workers-bindings-extension.0.0.0-v8cfa21641.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8cfa21641.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-create-cloudflare-8213 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-cloudflare-kv-asset-handler-8213

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-miniflare-8213

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-cloudflare-pages-shared-8213

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-cloudflare-unenv-preset-8213

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-cloudflare-vite-plugin-8213

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-cloudflare-vitest-pool-workers-8213

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-cloudflare-workers-editor-shared-8213

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-cloudflare-workers-shared-8213

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13460546256/npm-package-cloudflare-workflows-shared-8213

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit 459fbd7 into main Feb 21, 2025
16 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/d1-fixture branch February 21, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants