-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RPC method invocations showing up as unknown events #7811
Conversation
🦋 Changeset detectedLatest commit: 4ee4d28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-wrangler-7811 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7811/npm-package-wrangler-7811 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-wrangler-7811 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-cloudflare-workers-bindings-extension-7811 -O ./cloudflare-workers-bindings-extension.0.0.0-vca57438cc.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vca57438cc.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-create-cloudflare-7811 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-cloudflare-kv-asset-handler-7811 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-miniflare-7811 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-cloudflare-pages-shared-7811 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-cloudflare-unenv-preset-7811 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-cloudflare-vite-plugin-7811 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-cloudflare-vitest-pool-workers-7811 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-cloudflare-workers-editor-shared-7811 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-cloudflare-workers-shared-7811 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12897544650/npm-package-cloudflare-workflows-shared-7811 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
c73330a
to
3cf0223
Compare
3cf0223
to
119c9f6
Compare
@joshthoward LGTM overall 🚀 Regarding tests, I'm wondering if we can't test this use case in a similar way we do here or here or here, and mock the RPC events? |
119c9f6
to
4ee4d28
Compare
I didn't see that. These tests are added. |
Fix RPC method invocations showing up as unknown events. Users will now see the following in the case of either a
Service<MyWorkerEntrypoint>
or a DurableObjectNamespace` when invoking either from a worker: