Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the astro experimental template not to unnecessarily specify v2 for nodejs_compat #7565

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

dario-piotrowicz
Copy link
Member

This PR simply removes the extra _v2 that is not really needed in the Astro C3 experimental template


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: this is already tested
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no functional change

@dario-piotrowicz dario-piotrowicz added the e2e Run wrangler e2e tests on a PR label Dec 16, 2024
@dario-piotrowicz dario-piotrowicz requested review from a team as code owners December 16, 2024 14:49
Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: e7773bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 16, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-wrangler-7565

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7565/npm-package-wrangler-7565

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-wrangler-7565 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-cloudflare-workers-bindings-extension-7565 -O ./cloudflare-workers-bindings-extension.0.0.0-v96e4a607b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v96e4a607b.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-create-cloudflare-7565 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-cloudflare-kv-asset-handler-7565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-miniflare-7565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-cloudflare-pages-shared-7565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-cloudflare-vitest-pool-workers-7565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-cloudflare-workers-editor-shared-7565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-cloudflare-workers-shared-7565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12357940770/npm-package-cloudflare-workflows-shared-7565

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu force-pushed the dario/c3-astro-experimental-nodejs-compat-v2 branch from 23049a6 to e7773bc Compare December 16, 2024 17:24
@CarmenPopoviciu CarmenPopoviciu merged commit 8ad5be9 into main Dec 17, 2024
31 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the dario/c3-astro-experimental-nodejs-compat-v2 branch December 17, 2024 09:51
penalosa pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants