Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coroutines Conversion: convert more of server.c++/workerd.c++ #967

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Coroutines Conversion: convert more of server.c++/workerd.c++ #967

merged 1 commit into from
Aug 7, 2023

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 2, 2023

No description provided.

@jasnell jasnell requested review from kentonv and ohodson August 2, 2023 19:00
kentonv
kentonv approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@kentonv kentonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but we should fix the pre-existing bug mentioned below, either in this PR or a separate one.

src/workerd/server/server.c++ Show resolved Hide resolved
@jasnell jasnell force-pushed the jsnell/coroutines-conversion-more-server-workerd branch from 7d5df58 to 84d0dd6 Compare August 7, 2023 19:28
@jasnell jasnell merged commit e0d189b into main Aug 7, 2023
@jasnell jasnell deleted the jsnell/coroutines-conversion-more-server-workerd branch August 7, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentonv kentonv kentonv approved these changes

@ohodson ohodson Awaiting requested review from ohodson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasnell @kentonv