Fix linux-arm64 build release process #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of the `rules_python` package seems to have been updated recently which introduced a new error when the builder was being run as `root`. Since we're running this builder in a container, we can use the [`ignore_root_user_error`](https://github.com/bazelbuild/rules_python/blob/23354a9b607ff0207e9a3c0cbe16724ec53997c1/tests/ignore_root_user_error/README.md) option. There were also some issues installing the C++ toolchain and dependencies, so we're now deferring to the LLVM installation script to install these using the `all` argument.
dom96
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of the
rules_pythonpackage seems to have been updated recently which introduced a new error when the builder was being run asroot. Since we're running this builder in a container, we can use theignore_root_user_erroroption.There were also some issues installing the C++ toolchain and dependencies, so we're now deferring to the LLVM installation script to install these using the
allargument.