Enable WebSocket Compression in workerd
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When terminating a websocket in a worker (as a server), we need to access the client request's headers to determine what (if any) compression parameters should be used.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
kentonv
reviewed
Oct 4, 2022
kentonv
reviewed
Oct 4, 2022
kentonv
reviewed
Oct 4, 2022
kentonv
reviewed
Oct 4, 2022
kentonv
reviewed
Oct 4, 2022
By default, kj sets the compression mode to `NO_COMPRESSION`. We want to use `MANUAL_COMPRESSION` in Workerd so we modify the setting here.
MellowYarker
force-pushed
the
milan/enable-websocket-compression
branch
2 times, most recently
from
ce030b8 to
b49ad1e
Compare
kentonv
reviewed
Oct 4, 2022
If this flag is not set, we will strip `Sec-WebSocket-Extensions` from subrequests (including `new WebSocket()`) and responses.
MellowYarker
force-pushed
the
milan/enable-websocket-compression
branch
from
2873e9f to
5370f10
Compare
kentonv
approved these changes
Oct 5, 2022
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.