rtti: symbol table to lookup structures #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this it is now possible to fully handle recursive types.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
|
Wait its commit message says I signed but the commit content says you? And it still failed? |
This comment was marked as outdated.
This comment was marked as outdated.
|
@larcher We're still having trouble here. It actually managed to commit something but somehow still fails... |
kentonv
approved these changes
Sep 30, 2022
jasnell
approved these changes
Oct 1, 2022
|
recheck |
|
Grr CLAssistant is being annoying again. The requirement has obviously been met so I'm going to go ahead and override the check and merge. |
| @@ -2,6 +2,7 @@ | |||
| // Licensed under the Apache 2.0 license found in the LICENSE file or at: | |||
| // https://opensource.org/licenses/Apache-2.0 | |||
|
|
|||
| #include "src/workerd/api/actor.h" | |||
There was a problem hiding this comment.
This might need to be <workerd/api/actor.h>.
|
… On Wed, Oct 12, 2022 at 10:07 AM Harris Hancock ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/workerd/api/api-rtti-test.c++
<#66 (comment)>:
> @@ -2,6 +2,7 @@
// Licensed under the Apache 2.0 license found in the LICENSE file or at:
// https://opensource.org/licenses/Apache-2.0
+#include "src/workerd/api/actor.h"
This might need to be <workerd/api/actor.h>.
—
Reply to this email directly, view it on GitHub
<#66 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAZJBVJNZRS3NNNMCA7GLWC3V4HANCNFSM6AAAAAAQ2BTEWU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this it is now possible to fully handle recursive types.