Add support for deflate-raw and check for trailing or incomplete data in Compression Streams #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Feb 23, 2023
|
LGTM but internal CI and tests are needed. |
Abirhasan4
referenced
this pull request
Feb 24, 2023
Add `workerd test` for running unit tests under workerd
fhanau
force-pushed
the
felix/deflate-raw
branch
from
c787f56 to
1863ba1
Compare
|
All tests pass here and on the internal branch after rebasing, also adjusted a comment since the API does mandate an error when there is trailing data during decompression, including for deflate-raw. |
|
Test cases have been added on the internal PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With deflate-raw, we have all required data formats for the current Compression Streams API version. Also see the eponymous internal branch.