Remove the $experimental attribute on the nodejs_compat flag #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
requested review from
mikea,
kentonv and
harrishancock
and removed request for
mikea
jasnell
commented
Feb 14, 2023
| @@ -233,11 +233,8 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef { | |||
|
|
|||
| nodeJsCompat @21 :Bool | |||
| $compatEnableFlag("nodejs_compat") | |||
| $experimental; | |||
| # Experimental, do not use. | |||
| $compatDisableFlag("no_nodejs_compat") | |||
There was a problem hiding this comment.
Note that this intentionally does not yet add a default enable date.
There was a problem hiding this comment.
"Yet"? Do we plan to add one eventually or will it always be opt-in?
FWIW the disable flag is meaningless without a default enable date.
There was a problem hiding this comment.
Do we plan to add one eventually or will it always be opt-in?
I don't think we've settled 100% on that... yet ;-)
jasnell
force-pushed
the
jsnell/remove-nodejs-compat-experimental-gate
branch
from
cdad3aa to
5e09daa
Compare
jasnell
force-pushed
the
jsnell/remove-nodejs-compat-experimental-gate
branch
from
5e09daa to
549c0c4
Compare
kentonv
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.