Change TCP Socket's connect to take a SocketAddress struct.
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have links to other implementations that define it this way? IMO this makes the DX worse. |
jasnell
approved these changes
Feb 14, 2023
|
Could we support |
|
I'm good with supporting both, yeah. |
Good idea, will do. |
dom96
force-pushed
the
dominik/change-tcp-connect-arguments
branch
from
7a63189 to
795a518
Compare
dom96
force-pushed
the
dominik/change-tcp-connect-arguments
branch
from
795a518 to
c0ea735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to the API, but one that should make it more consistent with other implementations.
Tested upstream.