Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Python print()s not showing up in wrangler dev. #3555

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

dom96
Copy link
Collaborator

@dom96 dom96 commented Feb 14, 2025

It's not trivial to test this in workerd, but I will follow up with a test in workers-sdk.

Test Plan

bazel run @workerd//src/workerd/server/tests/python:hello_development@
Before

workerd/server/server.c++:4470: debug: [ TEST ] python-hello
Loading hashlib, lzma, pydecimal, pydoc-data, sqlite3, ssl
Loaded hashlib, lzma, pydecimal, pydoc-data, sqlite3, ssl
workerd/io/worker.c++:1871: info: console.log(); message() = ["Does this work?"]
Does this work?

After

workerd/server/server.c++:4470: debug: [ TEST ] python-hello
Loading hashlib, lzma, pydecimal, pydoc-data, sqlite3, ssl
Loaded hashlib, lzma, pydecimal, pydoc-data, sqlite3, ssl
Does this work?
Does this work?
workerd/server/server.c++:4478: debug: [ PASS ] python-hello

@dom96 dom96 requested review from a team as code owners February 14, 2025 18:00
@dom96 dom96 force-pushed the dominik/EW-9069-2 branch from 6571e6b to 0290fd9 Compare February 17, 2025 11:22
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fine but it would be nice to try to actually test this in workerd if possible.

@dom96 dom96 force-pushed the dominik/EW-9069-2 branch from 0290fd9 to b86458c Compare February 18, 2025 16:55
@dom96 dom96 merged commit 5565ce0 into main Feb 18, 2025
16 of 17 checks passed
@dom96 dom96 deleted the dominik/EW-9069-2 branch February 18, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants