Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial issue template for workers-types issues #354

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

lrapoport-cf
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lrapoport-cf
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@lrapoport-cf
Copy link
Contributor Author

recheck

@lrapoport-cf lrapoport-cf requested a review from a team February 9, 2023 01:06
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! If you add a single issue template, does GitHub always use that by default? Or would it show a screen like we have in Wrangler:
image


In any case, I'd be inclined to add regular issue templates for runtime issues/feature suggestions too.

.github/ISSUE_TEMPLATE/workers-types.md Outdated Show resolved Hide resolved
@lrapoport-cf
Copy link
Contributor Author

Nice! If you add a single issue template, does GitHub always use that by default? Or would it show a screen like we have in Wrangler: image

In any case, I'd be inclined to add regular issue templates for runtime issues/feature suggestions too.

@mrbbot the issue template documentation suggests that you should get the selection screen out of the box if you create issue templates using the issue template builder (which is what i used).

i just tried it in a test repo and it did indeed create the selection screen once i added my first issue template, so there should still be the option to open blank issues after this change 👍

image

i agree other issue templates would probably be a good idea, but i think that makes sense to do in other PRs

@jasnell
Copy link
Member

jasnell commented Feb 9, 2023

Since that "open a blank issue" is easy to miss, I wonder if it would be good to go ahead and add additional templates for reporting general bugs for workerd and feature requests?

Update: oh! ha! I missed @lrapoport-cf's last comment there about adding the other templates in other PRs

@lrapoport-cf lrapoport-cf merged commit 63d356b into main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants