stop reading empty buffers on node:net #3427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
reviewed
Jan 29, 2025
jasnell
reviewed
Jan 29, 2025
jasnell
approved these changes
Jan 29, 2025
anonrig
force-pushed
the
yagiz/stop-reading-empty-buffers
branch
4 times, most recently
from
5633046 to
530d541
Compare
anonrig
force-pushed
the
yagiz/stop-reading-empty-buffers
branch
from
530d541 to
6496636
Compare
jasnell
reviewed
Jan 29, 2025
jasnell
approved these changes
Jan 29, 2025
There is a test for it already in node:net which was printing an error on the log, but it's not at the moment. I think it's unnecessary since the following function has a similar check in 10 lines below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3425