Move initial Node.js polyfills to workerd #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/move-node-polyfills-to-workerd
branch
from
9c86202 to
c185c5e
Compare
mikea
approved these changes
Jan 31, 2023
| @@ -30,6 +30,6 @@ wd_api_bundle( | |||
| internal_modules = dict([( | |||
| m.removesuffix(".ts") + ".js", | |||
| "node-internal:" + m.removeprefix("internal/").removesuffix(".ts"), | |||
| ) for m in internal_modules]), | |||
| ) for m in internal_modules if not m.endswith(".d.ts")]), | |||
There was a problem hiding this comment.
thanks for taking care of this.
| @@ -2,7 +2,7 @@ | |||
| "compilerOptions": { | |||
| "target": "ESNext", | |||
| "module": "ESNext", | |||
| "lib": [ "ESNext" ], | |||
| "lib": [ "ESNext", "DOM" ], | |||
There was a problem hiding this comment.
todo for myself: replace this with either smaller definition or use generated .d.ts types (preferred).
| @@ -0,0 +1,17 @@ | |||
| import { EventEmitter } from 'node:events'; | |||
There was a problem hiding this comment.
you can also easily add an import test to https://github.com/cloudflare/workerd/blob/main/src/workerd/api/node/node-test.c%2B%2B (maybe for async context?)
There was a problem hiding this comment.
Yeah, I'll be porting the tests we have in the internal ew-test files out to here separately
jasnell
force-pushed
the
jsnell/move-node-polyfills-to-workerd
branch
from
c185c5e to
f58fa07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikea the key pieces to review here are the changes to the bazel build file and the tsconfig. Everything other than the sample modifications are a straight copy of the TS files.