Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow workerd inspector client to be fully trusted #329

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 30, 2023

Allows a workerd inspector client to be fully trusted, enabling a greater range of devtools capabilities (including memory profiling and timeline)

Copy link
Member

@kentonv kentonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really confused by the existing code which seems to handle many message types by reflecting them back to the client but that's not new in this PR.

@jasnell jasnell force-pushed the jsnell/workerd-inspector-trusted branch 2 times, most recently from 8808fe7 to 6127b8b Compare January 31, 2023 16:47
@jasnell jasnell force-pushed the jsnell/workerd-inspector-trusted branch from 6127b8b to 0b0d0c7 Compare February 2, 2023 21:25
@jasnell jasnell merged commit 24dc474 into main Feb 2, 2023
@jasnell jasnell deleted the jsnell/workerd-inspector-trusted branch February 2, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants