Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a catch-all experimental compatibility flag for incremental work #312

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 25, 2023

Will be used, for instance, to incrementally work on experimental Node.js compatibility stuff separately from the nodejs_compat flag that will be used to enable the stuff that's stable.

@jasnell
Copy link
Member Author

jasnell commented Jan 25, 2023

Not 100% convinced this is the right direction. @kentonv had suggested the catch-all as a possible approach so wanted to write it up really quick. Do we really want to do it this way or have more specific flags?

@kentonv
Copy link
Member

kentonv commented Jan 25, 2023

Yes, this is what I had in mind.

To explain, the idea here is we'd use this in cases where the change being guarded is expected to be backwards-compatible, and thus no compat flag is needed in the long term, but we still want to block use of the API until it stabilizes. This way we don't end up with a proliferation of obsolete compat flags.

I still like this idea but am open to arguments why we wouldn't want to do it this way...

@jasnell
Copy link
Member Author

jasnell commented Jan 25, 2023

open to arguments why we wouldn't want to do it this way...

Just a general concern about it potentially being abused, but no strong feelings either way.

@jasnell jasnell force-pushed the jsnell/add-catchall-experimental-flag branch from 967a814 to 4008d5b Compare January 25, 2023 17:32
@jasnell
Copy link
Member Author

jasnell commented Jan 25, 2023

Rebased to clear the merge conflict

src/workerd/io/compatibility-date.capnp Show resolved Hide resolved
src/workerd/io/compatibility-date.capnp Outdated Show resolved Hide resolved
@jasnell
Copy link
Member Author

jasnell commented Jan 26, 2023

Let's not land this yet until the discussion about the nodejs-compat flag is settled. We may be able to repurpose that flag instead of adding a new one. Ok, looks like we're going to stick with the nodejs-compat flag

@jasnell jasnell force-pushed the jsnell/add-catchall-experimental-flag branch 2 times, most recently from 35ead79 to ff6bccc Compare January 27, 2023 23:36
Will be used, for instance, to incrementally work on experimental
Node.js compatibility stuff separately from the nodejs_compat flag
that will be used to enable the stuff that's stable.
@jasnell jasnell force-pushed the jsnell/add-catchall-experimental-flag branch from ff6bccc to 4861f93 Compare January 27, 2023 23:53
@jasnell
Copy link
Member Author

jasnell commented Jan 27, 2023

recheck

@jasnell jasnell merged commit bd21707 into main Jan 30, 2023
@jasnell jasnell deleted the jsnell/add-catchall-experimental-flag branch January 30, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants