Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "simple test-fixture (#263)" #290

Closed
wants to merge 1 commit into from
Closed

Revert "simple test-fixture (#263)" #290

wants to merge 1 commit into from

Conversation

edevil
Copy link
Contributor

@edevil edevil commented Jan 19, 2023

This reverts commit 101a34b.

This commit is currently breaking edgeworker tests.

external/workerd/src/workerd/tests/test-fixture.c++:215:17: error: no member named 'any_of' in namespace 'std'
    return std::any_of(errorsToIgnore.begin(), errorsToIgnore.end(), [&description](auto error) {
           ~~~~~^

@mikea
Copy link
Contributor

mikea commented Jan 19, 2023

Sorry for this. I wonder why didn't build catch it? looks like <algorithm> is included on some platforms and not others.

In any case, since this is still open, let's consider a trivial fix in #291

@jasnell
Copy link
Member

jasnell commented Jan 19, 2023

Awesome, ok, will close in favor of #291

@jasnell jasnell closed this Jan 19, 2023
@jasnell jasnell self-assigned this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants