fix email info declaration #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmailInfo attributes were incorrectly declared which prevented them from being serialized into the trace event.
jasnell
reviewed
Jan 19, 2023
| JSG_READONLY_PROTOTYPE_PROPERTY(rawSize, getRawSize); | ||
| JSG_READONLY_INSTANCE_PROPERTY(mailFrom, getMailFrom); | ||
| JSG_READONLY_INSTANCE_PROPERTY(rcptTo, getRcptTo); | ||
| JSG_READONLY_INSTANCE_PROPERTY(rawSize, getRawSize); |
There was a problem hiding this comment.
Is this because the structure is JSON stringified? If so, a better long term solution here is to implement a toJSON method. This change is good for now but let me explore the toJSON approach separately
There was a problem hiding this comment.
That is correct. This Event object will be JSON.stringified() by the Tracer in edgeworker.
There was a problem hiding this comment.
ok yeah, I'll work up a generic toJSON mechanism that will make this easier. In general the reason we want to avoid JSG_*_INSTANCE_PROPERTY is that it forces the objects to stay alive longer than they otherwise need to be rather than being gc'd earlier.
jasnell
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmailInfo attributes were incorrectly declared which prevented them from being serialized into the trace event.