Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "node compatibility typescript infrastructure"" #273

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

mikea
Copy link
Collaborator

@mikea mikea commented Jan 13, 2023

Third time's the charm. No changes, just rebased on top of fresh capnp revision.

This reverts commit e88bae5.

@mikea mikea marked this pull request as ready for review January 13, 2023 22:30
@jasnell
Copy link
Member

jasnell commented Jan 17, 2023

Is there a corresponding internal PR with a good CI run?

@mikea mikea force-pushed the maizatskyi/2023-01-13-node_infra branch 2 times, most recently from b0cc476 to f6a4d56 Compare January 17, 2023 18:04
@mikea mikea marked this pull request as draft January 17, 2023 18:11
@mikea mikea force-pushed the maizatskyi/2023-01-13-node_infra branch from f6a4d56 to bb7927b Compare January 17, 2023 20:09
@mikea mikea marked this pull request as ready for review January 17, 2023 20:36
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the internal CI comes up green.

@mikea mikea merged commit f1df19f into main Jan 17, 2023
@mikea mikea deleted the maizatskyi/2023-01-13-node_infra branch January 17, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants