Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "node compatibility typescript infrastructure" #269

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

harrishancock
Copy link
Collaborator

@harrishancock harrishancock marked this pull request as ready for review January 13, 2023 16:05
@edevil edevil self-requested a review January 13, 2023 16:06
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the second time this has had to be reverted :-/

@harrishancock harrishancock merged commit 002cf0d into main Jan 13, 2023
@mikea
Copy link
Contributor

mikea commented Jan 13, 2023

very weird. It works for me locally.

@mikea mikea deleted the harris/revert-node-compat-infra-again branch January 13, 2023 17:31
@mikea
Copy link
Contributor

mikea commented Jan 13, 2023

I think I know why this has happened:

  • capnp dependency doesn't have my cc_capnp_library change (
    urls = ["https://github.com/capnproto/capnproto/tarball/6a1dcb8e4b2864b95e4be43ed6314f5334d457fa"],
    )
  • it works locally for me because I've overwritten capnp dependency locally to include my change.

Looks like updating capnp+relanding the change should work this time :)

cc @harrishancock @jasnell

@mikea
Copy link
Contributor

mikea commented Jan 13, 2023

#272 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants