new event info type email #249
Conversation
|
@jasnell, unrelated to this specific PR, but should the prototype property change (#249 (comment)) be extended to all the other similar EventInfo types, potentially with a compatibility flag? |
We should likely start transitioning those, yes, but not sure how much of a priority it is. |
Added new event info type for email events. This will contain the from, to and raw size of the email.
|
|
||
| private: | ||
| kj::Own<Trace> trace; | ||
| const Trace::EmailEventInfo& eventInfo; |
There was a problem hiding this comment.
I don't believe this is a new problem at all but I do generally have a concern about using const refs in jsg::Objects like this. What guarantee do we have that the ref is going to stay alive for as long as the JS wrapper? For instance, if someone happens to store the info object at global scope, for instance, what happens when the properties are accessed?
There was a problem hiding this comment.
I agree, we should look at this.
Added new event info type for email events. This will contain the from, to and raw size of the email.