Introduce move-inhibiting version of KJ_DISALLOW_COPY #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrishancock
force-pushed
the
harris/move-inhibiting-disallow-copy
branch
from
d451167 to
a0382d0
Compare
harrishancock
force-pushed
the
harris/move-inhibiting-disallow-copy
branch
from
f384df7 to
355aad1
Compare
This is needed to pick up the new KJ_DISALLOW_COPY_AND_MOVE macro.
This commit is not intended to be merged as-is, because it is currently a source-incompatible change. Rather, it is intended to prove that we have retrofitted all existing uses of KJ_DISALLOW_COPY to only appear in cases where move semantics are not required. A later commit will rename KJ_DISALLOW_COPY to KJ_DISALLOW_COPY_AND_MOVE, and then rename KJ_DISALLOW_ONLY_COPY back to KJ_DISALLOW_COPY, making this a source-compatible change.
This converts the previous commit to a source-compatible change, and introduces a better name for the move-inhibiting version of this macro: KJ_DISALLOW_COPY_AND_MOVE.
My first pass was very mechanical, and I missed that these could be improved.
harrishancock
force-pushed
the
harris/move-inhibiting-disallow-copy
branch
from
c1ef0a4 to
2343db5
Compare
|
Seems like the commit messages may need updating (one says it shouldn't be merged) and maybe the commits should be squashed? |
kentonv
approved these changes
Dec 22, 2022
Eh I don't care that much, up to you. |
|
Normally I would agree and squash these down, now that the change is stable. However, since this is a change across three different repos, our CIs take a long time, and the probability of becoming conflicted is relatively high, I'm going to merge while CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is not intended to be merged as-is, because it is currently a source-incompatible change. Rather, it is intended to prove that we have retrofitted all existing uses of KJ_DISALLOW_COPY to only appear in cases where move semantics are not required.
A later commit will rename KJ_DISALLOW_COPY to KJ_DISALLOW_COPY_AND_MOVE, and then rename KJ_DISALLOW_ONLY_COPY back to KJ_DISALLOW_COPY, making this a source-compatible change.
Edit: the later commit has been pushed, and capnproto dependency updated. Ready to merge.