Implement missing Worker::Isolate::SubrequestClient::connect. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
Dec 20, 2022
Yes, probably. I wonder if you could redeclare the method pure-virtual at the |
kentonv
approved these changes
Dec 20, 2022
dom96
force-pushed
the
dominik/implement-missing-subrequest-connect
branch
from
c0cb7ed to
2c26468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing via fiddle this code path was hit.
@kentonv should
connectbe implemented in all classes which extend WorkerInterface/HttpService? if not are there any otherconnectcodepaths which are likely to be hit in production and so should be implemented?