Update hex checks to ignore Fullwidth ASCII characters #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jasnell
approved these changes
Dec 16, 2022
kentonv
reviewed
Dec 16, 2022
|
I have read the CLA Document and I hereby sign the CLA. |
vickykont
force-pushed
the
vasiliki/fix-hex-checks
branch
from
6713aec to
581a6f9
Compare
jasnell
reviewed
Dec 17, 2022
vickykont
force-pushed
the
vasiliki/fix-hex-checks
branch
from
581a6f9 to
be6c0fa
Compare
|
Should be alright now. Please, take another look. |
|
still LGTM |
kentonv
approved these changes
Dec 17, 2022
vickykont
force-pushed
the
vasiliki/fix-hex-checks
branch
from
be6c0fa to
2f1b280
Compare
|
Last force push is a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.