Experimental code cache for built-in js/ts modules #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/builtin-modules-experimental-codecache
branch
from
fb042d0 to
4db166c
Compare
|
Won't this use unbounded memory as more and more different workers are loaded over time? It seems like we would need some sort of eviction mechanism for these? |
|
Never mind, I didn't get that this is for built-in modules only. This makes tons of sense for built-ins. |
|
Yeah, I have no intention of using this for worker bundles for the time being. |
jasnell
force-pushed
the
jsnell/builtin-modules-external-strings
branch
from
6ba1d7f to
d73efd5
Compare
kentonv
reviewed
Dec 7, 2022
jasnell
force-pushed
the
jsnell/builtin-modules-experimental-codecache
branch
from
4db166c to
dbd18ce
Compare
jasnell
force-pushed
the
jsnell/builtin-modules-external-strings
branch
from
983ad7f to
a423774
Compare
Base automatically changed from
jsnell/builtin-modules-external-strings
to
main
December 9, 2022 20:49
jasnell
force-pushed
the
jsnell/builtin-modules-experimental-codecache
branch
from
dbd18ce to
8f21c0c
Compare
kentonv
reviewed
Dec 9, 2022
kentonv
reviewed
Dec 9, 2022
kentonv
reviewed
Dec 9, 2022
kentonv
reviewed
Dec 9, 2022
kentonv
reviewed
Dec 9, 2022
jasnell
force-pushed
the
jsnell/builtin-modules-experimental-codecache
branch
from
ced1492 to
23a4327
Compare
kentonv
reviewed
Dec 10, 2022
kentonv
reviewed
Dec 10, 2022
kentonv
reviewed
Dec 10, 2022
kentonv
approved these changes
Dec 16, 2022
jasnell
force-pushed
the
jsnell/builtin-modules-experimental-codecache
branch
from
0d2ccfc to
898180d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #201 which would need to land firstImplements a per-process cache for compiled built-in js/ts modules aimed at reducing the peformance impact of loading those repeatedly across many isolates.
This is purely experimental right now so this PR will remain as a draft for the time being.