Add scripts tags to Trace Workers #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for script tags in trace events by introducing an optional string array property on TraceItem called "scriptTags".
ObsidianMinor
approved these changes
Nov 23, 2022
jasnell
approved these changes
Nov 24, 2022
zebp
added a commit
to zebp/workerd
that referenced
this pull request
Dec 2, 2022
This reverts commit 464c154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for script tags in trace events by introducing an optional string array property on
TraceItemcalledscriptTags. Because most Workers will never have script tags on them this property is optional and undefined if no tags are defined.