Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overrides for Analytics Engine #172

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Add overrides for Analytics Engine #172

merged 2 commits into from
Nov 15, 2022

Conversation

jimhawkridge
Copy link
Contributor

We want the Analytics Engine binding to be of type AnalyticsEngineDataset and the events to be of type AnalyticsEngineDataPoint.

@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

jasnell
jasnell approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please be sure to post the CLA agreement comment :-)

@jimhawkridge
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 15, 2022
@github-actions
@jimhawkridge has signed the CLA from Pull Request #172
54860a7
@jasnell jasnell merged commit a90ff37 into cloudflare:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mrbbot mrbbot mrbbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimhawkridge @jasnell @mrbbot