Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a remote bazel cache to speed up builds #153

Merged
merged 7 commits into from
Nov 8, 2022

Conversation

penalosa
Copy link
Collaborator

@penalosa penalosa commented Nov 3, 2022

No description provided.

@kentonv
Copy link
Member

kentonv commented Nov 4, 2022

There are some "413 Request Entity Too Large" errors in the build log, is that bad? I guess it still finished (and in 7m, which is awesome).

@penalosa
Copy link
Collaborator Author

penalosa commented Nov 4, 2022

I think it's fine (if an object fails to get cached it's not ideal, but equally it won't break the build). They're coming from Cloudflare, so I can follow and try and figure out what's going on, and if the limit can be raised (I guess we have a default limit at the edge?)

@penalosa
Copy link
Collaborator Author

penalosa commented Nov 8, 2022

To follow up on the limit, I think this is just hitting a default for workers.dev. It'll only fail on the largest of uploads. I don't think this is a blocker for this being merged though

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

Can we squash this before merging though?

@penalosa penalosa merged commit a121d9d into main Nov 8, 2022
@kentonv kentonv deleted the penalosa/caching-for-tests branch December 7, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants