Remove id parameter from IsolateObserver::created()
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrishancock
force-pushed
the
harris/remove-id-from-isolate-observer-created
branch
from
e41f654 to
d1be321
Compare
vickykont
approved these changes
Nov 2, 2022
dom96
approved these changes
Nov 3, 2022
jasnell
approved these changes
Nov 3, 2022
This turned out to be unnecessary, since implementations of IsolateObserver can already receive arbitrary identifiers by other means.
harrishancock
force-pushed
the
harris/remove-id-from-isolate-observer-created
branch
from
d1be321 to
61f1ad4
Compare
harrishancock
deleted the
harris/remove-id-from-isolate-observer-created
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be unnecessary, since implementations of IsolateObserver can already receive arbitrary identifiers by other means.