Improved support for readAtLeast byob reads #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
commented
Oct 25, 2022
jasnell
force-pushed
the
jsnell/stream-respond-minimum
branch
2 times, most recently
from
483370a to
562ee01
Compare
jasnell
requested review from
kentonv,
harrishancock,
mikea,
jclee,
a-robinson,
bretthoerner and
byule
as code owners
jasnell
commented
Oct 25, 2022
jasnell
force-pushed
the
jsnell/stream-respond-minimum
branch
from
562ee01 to
1f9d2ba
Compare
harrishancock
approved these changes
Oct 27, 2022
jasnell
force-pushed
the
jsnell/stream-respond-minimum
branch
2 times, most recently
from
dba697a to
2a1a311
Compare
* Allows multiple respond/respondWithNewView to partially resolve readAtLeast byob reads. * Fix IdentityTransformStream minBytes calculation * Properly calculate atLeast with multi-byte views
jasnell
force-pushed
the
jsnell/stream-respond-minimum
branch
from
d4617e1 to
ee79d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @harrishancock