Fixup MessageEvent.data regression #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/fixup-websocket-messageevent-data
branch
from
463d741 to
8d80fc6
Compare
ObsidianMinor
approved these changes
Sep 10, 2023
harrishancock
approved these changes
Sep 11, 2023
MessageEvent.data should be an `ArrayBuffer` if the data is bytes. The recent JsValue conversion accidentally changed it to `Uint8Array`.
jasnell
force-pushed
the
jsnell/fixup-websocket-messageevent-data
branch
from
8d80fc6 to
59dd148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageEvent.data should be an
ArrayBufferif the data is bytes. The recent JsValue conversion accidentally changed it toUint8Array.