Nest getActor tracing spans under "actor_subrequest" spans #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Aug 31, 2023
jasnell
reviewed
Aug 31, 2023
jclee
force-pushed
the
jlee/tweak-getactor-nesting
branch
from
910774b to
550a880
Compare
jasnell
approved these changes
Aug 31, 2023
…d under "actor_subrequest" spans This does have the side effect of skipping the lazy actor stub initialization if an intervening step of the fetcher setup fails (e.g. when the worker is over request limits), but I think this is unlikely to have user-visible behavior, and may in fact be desirable, in that it avoids unnecessary getActor() calls.
jclee
force-pushed
the
jlee/tweak-getactor-nesting
branch
from
550a880 to
eb24505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify actor channel setup to let
getActortracing spans appear nested underactor_subrequestspans, instead of under the context's "current" spanThis change does have the side effect of skipping the lazy actor stub initialization if an intervening step of the fetcher setup fails (e.g. when the worker is over request limits), but I think this is unlikely to have user-visible behavior, and may in fact be desirable, in that it avoids unnecessary
getActor()calls.