[nfc] api headers benchmark #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikea
force-pushed
the
maizatskyi/2023-08-29-api-headers-bench
branch
from
c4844b4 to
848351d
Compare
fhanau
reviewed
Aug 30, 2023
| } | ||
|
|
||
| void TearDown(benchmark::State& state) noexcept(true) override { | ||
| fixture = nullptr; |
There was a problem hiding this comment.
PR LGTM overall, but can you explain what the virtual destructor and fixture = nullptr; statements are used for? I'd imagine that the virtual destructor means that just the benchmark::Fixture destructor is used and that fixture is set to nullptr so that kj::Own knows it can free it.
There was a problem hiding this comment.
virtual destructor is needed to annotate it by noexcept. otherwise in our code base clang assumes it has a different exception specification.
I use fixture = null to force- destroy an Isolate. Not entirely sure what's the fixture lifecycle yet.
fhanau
approved these changes
Aug 30, 2023
…yi/2023-08-29-api-headers-bench
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.