[nfc] remove off-by-default bench tag

[mikea]

bazel doesn't build/run it otherwise. It doesn't hurt if there's none, since run target are not run by bazel test.

[fhanau]

If we remove the tag, this will be included in bazel build //..., which builds all targets (but does not run tests), causing all benchmarks to be built and run on CI as bazel build //... is the first CI build step and building the csv output file causes the benchmark to be run. This could be avoided by adding --build_tests_only, but that might also end up not building things that we want to be built (e.g. the api_encoder, which is not a dependency of any tests but we still want to be able to see if any ).
Running benchmarks on CI by default is something we can do, but it merits prior discussion.

[fhanau]

See comment above

[mikea]

If we remove the tag, this will be included in bazel build //..., which builds all targets (but does not run tests), causing all benchmarks to be built and run on CI as bazel build //... is the first CI build step and building the csv output file causes the benchmark to be run. This could be avoided by adding --build_tests_only, but that might also end up not building things that we want to be built (e.g. the api_encoder, which is not a dependency of any tests but we still want to be able to see if any ). Running benchmarks on CI by default is something we can do, but it merits prior discussion.

hm... My thinking was that "off-by-default" on csv will still prevent us from generating csv on CI. If I take a look into build logs I don't see any evidence of us running benchmarks either.

building benchmarks during CI is actually a good thing, we don't wan't them to be stale.

[fhanau]

Ok, I see that "off-by-default" still applies for the benchmark csv. In that case we can go ahead, building benchmarks on CI should be acceptable.