Relax gc visitation on streams queued ReadRequest #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrishancock
approved these changes
Aug 28, 2023
jasnell
force-pushed
the
jsnell/relax-gc-visit-streams-readrequest
branch
from
8c06b99 to
55e1738
Compare
There's no reason to gc visit the promise resolver here and it is potentially problematic if we do. Since the read requests are queued, if we gc visit it once, remove it from the queue, and gc happens to kick in before we access the resolver, then v8 could determine that the resolver is not reachable via tracing any more and free it before we can actually try to access the held resolver.
jasnell
force-pushed
the
jsnell/relax-gc-visit-streams-readrequest
branch
from
55e1738 to
d193bcd
Compare
|
This passed internal CI. Windows github action appears to be persistently broken somehow completely unrelated to this fix. I ran windows build and test locally to verify so I'm going to go ahead and override the CI gate here and merge. There's another PR to try to figure out the Windows github issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason to gc visit the promise resolver here and it is potentially problematic if we do. Since the read requests are queued, if we gc visit it once, remove it from the queue, and gc happens to kick in before we access the resolver, then v8 could determine that the resolver is not reachable via tracing any more and free it before we can actually try to access the held resolver.