Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsg: adding long long types to rtti #106

Merged
merged 1 commit into from
Oct 14, 2022
Merged

jsg: adding long long types to rtti #106

merged 1 commit into from
Oct 14, 2022

Conversation

mikea
Copy link
Contributor

@mikea mikea commented Oct 14, 2022

Some unsigned long linux types are unsigned long long on mac.

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but expanding the commit message a bit to explain why would be helpful.

Some unsigned long linux types are unsigned long long on mac.
@mikea mikea force-pushed the mikea/more_rtti_types branch from 84b410d to c48246a Compare October 14, 2022 18:49
@mikea mikea merged commit 76ebeda into main Oct 14, 2022
@mikea mikea deleted the mikea/more_rtti_types branch October 14, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants