-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add toJSON implementation for R2Checksums #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frederik-Baetens
requested review from
kentonv,
jasnell,
harrishancock,
mikea,
jclee,
a-robinson,
bretthoerner and
byule
as code owners
October 14, 2022 00:37
Frederik-Baetens
force-pushed
the
fbaetens/R2-checksums-json
branch
2 times, most recently
from
October 14, 2022 01:09
ef85766
to
1fab8a4
Compare
jasnell
approved these changes
Oct 17, 2022
jasnell
approved these changes
Oct 19, 2022
Frederik-Baetens
force-pushed
the
fbaetens/R2-checksums-json
branch
from
October 19, 2022 21:01
ed586d1
to
f263478
Compare
Frederik-Baetens
force-pushed
the
fbaetens/R2-checksums-json
branch
from
October 19, 2022 21:07
f263478
to
451ce5e
Compare
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Jan 10, 2023
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Jan 17, 2023
* Coerce R2 keys to `string`s The Workers runtime coerces arguments if the C++ type is a string. It will only throw if the parameter isn't specified at all. * Accept multiple keys in `R2Bucket#delete()`, closes #420 Ref: https://community.cloudflare.com/t/2022-9-16-workers-runtime-release-notes/420496 * Implement `r2_list_honor_include` compatibility flag Ref: https://developers.cloudflare.com/workers/platform/compatibility-dates/#r2-bucket-list-respects-the-include-option * Allow `R2Bucket#get()` range to be specified as a `Range` header Miniflare already had code for parsing `Range` headers for the Cache API, so this was moved to `@miniflare/shared` and reused here. Ref: https://community.cloudflare.com/t/2022-8-12-workers-runtime-release-notes/410873 * Implement R2 `SHA-*` checksums and return from `R2Bucket#{get,head}` Ref: https://community.cloudflare.com/t/2022-9-16-workers-runtime-release-notes/420496 Ref: cloudflare/workerd#103 * fixup! Implement R2 `SHA-*` checksums and return from `R2Bucket#{get,head}`
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Feb 25, 2023
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Feb 27, 2023
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Feb 27, 2023
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Feb 27, 2023
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Mar 11, 2023
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
Mar 11, 2023
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Oct 31, 2023
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Nov 1, 2023
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Nov 1, 2023
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows JSON.stringify() to work on the result of head/list again