Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variation of jsg::Function that takes jgs::Arguments<jsg::Value> #1029

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 17, 2023

Variation of jsg::Function that takes a jsg::Argumentsjsg::Value

@jasnell jasnell changed the title Allow overriding the received (this) of a jsg::Function Variation of jsg::Function that takes jgs::Varargs Aug 17, 2023
@jasnell jasnell force-pushed the jsnell/jsg-function-varargs-variant branch from 2c286d9 to c7a99d6 Compare August 17, 2023 22:08
@jasnell jasnell changed the title Variation of jsg::Function that takes jgs::Varargs Variation of jsg::Function that takes jgs::Arguments<jsg::Value> Aug 17, 2023
@jasnell jasnell marked this pull request as ready for review August 17, 2023 22:09
@jasnell jasnell requested review from kentonv, ohodson and mikea August 17, 2023 22:09
@jasnell jasnell force-pushed the jsnell/jsg-function-override-receiver branch from b6131ee to 7d8521c Compare August 18, 2023 16:50
@jasnell jasnell force-pushed the jsnell/jsg-function-varargs-variant branch 2 times, most recently from 83d3515 to fab934c Compare August 18, 2023 17:54
@jasnell jasnell force-pushed the jsnell/jsg-function-varargs-variant branch from fab934c to 44f0d37 Compare August 18, 2023 18:19
Base automatically changed from jsnell/jsg-function-override-receiver to main August 18, 2023 18:24
@jasnell jasnell merged commit af7582b into main Aug 18, 2023
@fhanau fhanau deleted the jsnell/jsg-function-varargs-variant branch December 4, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants