Allow overriding the received (this) of a jsg::Function, update forEach impls #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohodson
reviewed
Aug 17, 2023
|
lgtm modulo my naive question about value vs object for the receiver. Probably good to have a second opinion though. |
ohodson
approved these changes
Aug 18, 2023
The jsg::Function will automatically set the receiver when mapping from a JS function to jsg::Function. This is not always what we want. In many cases we have to be able to override the receiver on a case by case basis.
jasnell
force-pushed
the
jsnell/jsg-function-override-receiver
branch
from
b6131ee to
7d8521c
Compare
Warfields
reviewed
Aug 18, 2023
| jsg::Optional<jsg::Value> thisArg); | ||
| void forEach(jsg::Lock&, | ||
| jsg::Function<void(kj::StringPtr, kj::StringPtr, jsg::Ref<URLSearchParams>)>, | ||
| jsg::Optional<jsg::Value>); |
There was a problem hiding this comment.
Possibly just learned something about c++, just want to verify before I make any assumptions. Can you always just list types in the header, and then let the implementation name the variables or is this a special case?
There was a problem hiding this comment.
Yep. I know there are differences of opinion on this about whether it is desirable but personally I prefer the more abbreviated form in declarations when the intent is clear.
Warfields
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jsg::Function will automatically set the receiver when mapping
from a JS function to jsg::Function. This is not always what we want.
In many cases we have to be able to override the receiver on a case
by case basis. This pr introduces the ability to change the receiver
on a jsg::Function, and updates the various forEach method impls to
use jsg::Function instead of directly using v8::Function calls.