Implement microbenchmark #1022
Merged
Implement microbenchmark #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohodson
reviewed
Aug 16, 2023
src/workerd/tests/bench-tools.h
Outdated
|
|
||
| namespace workerd::microbench { | ||
|
|
||
| } // namespace workerd::api::microbench |
There was a problem hiding this comment.
The namespace on L31 doesn't align with L29, but neither is likely necessary in this PR. JFYI, most of the files in workerd/test just emit their bits in the workerd namespace.
ohodson
approved these changes
Aug 16, 2023
|
It'd be good to have the benchmark repro step in the commit message and the ticket, just to provide some initial context for anyone who wants it in future. |
Adds a simple interface for defining microbenchmarks, use `bazel run //src/workerd/tests:bench-json` to run the provided example benchmark.
fhanau
force-pushed
the
felix/microbench-v1
branch
from
a8ad9c4 to
1dfb318
Compare
|
Thanks for the quick review! I removed the namespace for the time being and added the bazel command as suggested. |
|
FWIW KJ_TEST already has some benchmark functionality built in, see http-over-capnp-perf-test.c++ in the capnp repo for an example. I'm sure Google's thing has a lot more features though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a microbenchmark based on google/microbenchmark. This includes bazel integration for the library, defining the
wd_cc_benchmark()target rule and adding an example benchmark.There is also a header with convenience macros for benchmarking, including
WD_BENCH()which is not yet used but can serve as a drop-in replacement for KJ_TEST() to make it easy to benchmark many of our existing tests. The felix/microbench-poc branch expands on this, but contains more experimental work; this PR is intended to land the microbenchmark and allow developers to define simple benchmarks, usebazel run //src/workerd/tests:bench-jsonto check it out!