Fixup use-after-free error in streams tee #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
requested review from
kentonv,
harrishancock,
mikea,
jclee,
a-robinson,
bretthoerner and
byule
as code owners
|
/cc @harrishancock @mikea |
jasnell
commented
Oct 13, 2022
| @@ -1660,10 +1660,14 @@ ReadableStreamJsController::ReadableStreamJsController( | |||
| : state(consumer.clone(js, this)) {} | |||
|
|
|||
| ReadableStreamJsController::ReadableStreamJsController(kj::Own<ValueReadable> consumer) | |||
| : state(kj::mv(consumer)) {} | |||
| : state(kj::mv(consumer)) { | |||
| state.get<kj::Own<ValueReadable>>()->setOwner(this); | |||
There was a problem hiding this comment.
Root cause here is that the ValueReadable and ByteReadable were retaining the pointer to the previous owner. ReadableStreamJsSource was handling this case properly but missed it here.
jasnell
force-pushed
the
jsnell/maybe-fix-tee-uaf
branch
from
8349243 to
04d1f09
Compare
harrishancock
approved these changes
Oct 14, 2022
harrishancock
added a commit
that referenced
this pull request
Oct 24, 2022
This reverts commit 39a3365.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.